On 02/10/2014 03:03 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > Enter Edit->Connection Details, in tab: > Virtual Networks, Storage and Network Interfaces, > images of icon stop-XXX and delete-XXX > look so simmilar. > We should change them to gtk-remove: > 1) blue icon, can be easily distinguished from > red stop icon aside. > 2) we've already used gtk-add for adding device. > > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > --- > ui/host.ui | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ui/host.ui b/ui/host.ui > index 06d761f..78e02ca 100644 > --- a/ui/host.ui > +++ b/ui/host.ui > @@ -1225,7 +1225,7 @@ > <object class="GtkImage" id="image13"> > <property name="visible">True</property> > <property name="can_focus">False</property> > - <property name="stock">gtk-delete</property> > + <property name="stock">gtk-remove</property> > </object> > </child> > </object> > @@ -1769,7 +1769,7 @@ > <object class="GtkImage" id="image7"> > <property name="visible">True</property> > <property name="can_focus">False</property> > - <property name="stock">gtk-delete</property> > + <property name="stock">gtk-remove</property> > </object> > </child> > </object> > @@ -2468,7 +2468,7 @@ here</property> > <object class="GtkImage" id="image9"> > <property name="visible">True</property> > <property name="can_focus">False</property> > - <property name="stock">gtk-delete</property> > + <property name="stock">gtk-remove</property> > </object> > </child> > </object> > I agree that the icons look too similar, but unfortunately that's a fault of the gtk icon theme and not virt-manager. Remove is just a blue '-' here which isn't too obvious either, especially since 'delete' is a potentially dangerous operation. I wish they would have just kept the old trashcan icon since everyone understands that, but it's their bug not ours IMO. - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
