On 02/06/2014 04:40 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > This patch provides the ability to > tune Blkio cgroup tunable parameters for the domain. > Thanks! Code looks fine, so please push. But can you check add a few additional things? - Add a <blkiotune> element to testdriver.xml test-many-devices. You might need to do python setup.py tests --regenerate-output after this, since it will likely alter some of the diffs we track as test output. - Add a couple clitests for virt-xml: --edit compare and --build-xml should work. You will probably need to tweak cli.py to make --build-xml work. - Add a --blkiotune example to the many-devices compare test in clitest.py Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
