On 01/29/2014 11:43 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
>
> commit 64b2d0c6b7804f3501bfd8b657346776a8849879
> forget to check settype and pylint complains this
> as Unused variable.
> This patch will fix this.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> ---
> virtManager/gfxdetails.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/virtManager/gfxdetails.py b/virtManager/gfxdetails.py
> index 28ca332..2bc6c3a 100644
> --- a/virtManager/gfxdetails.py
> +++ b/virtManager/gfxdetails.py
> @@ -199,7 +199,8 @@ class vmmGraphicsDetails(vmmGObjectUI):
> if is_other:
> settype = gfx.pretty_type_simple(gtype)
>
> - uiutil.set_combo_entry(self.widget("graphics-type"), gtype, 0)
> + if settype:
> + uiutil.set_combo_entry(self.widget("graphics-type"), gtype, 0)
> return title
>
>
>
I pushed a different fix yesterday
- Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
