On 01/29/2014 12:46 PM, Chen Hanxiao wrote: > At 2014-01-29 21:50:22,"Cole Robinson" <crobinso@xxxxxxxxxx> wrote: > >>On 01/29/2014 03:53 AM, Chen Hanxiao wrote: >>> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >>> >>> This patch will add support for adding multiple >>> default consoles, with command: >>> >>> virt-install --console N >>> >> >>We don't use that format anywhere else. If someone wants to attach multiple >>devices should do: --console OPTS --console OPTS ... >> >>So maybe add a '--console default' handler and allow that to be specified >>multiple times. And please add a cli compare test so we know it's doing the >>right thing. > > If we add two pty consoles for vm： > > virt-install --debug --connect test:////root/virt-manager/tests/testdriver.xml --name foobar --ram 64 --hvm --nographics --noautoconsole --nodisks --pxe --console pty --console pty > > We will get an error > > libvirtError: unsupported configuration: Only the first console can be a serial port > > Container works fine with adding two pty consoles. > > What kind of default console shoud we provided for vm? Maybe separate from add_default_console_device a function build_default_console_device. map --console default to that. (also, your patches are fine but your mail client seems to be sending html emails, can you switch to plain text?) Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
