At 2014-01-27 23:10:04,"Cole Robinson" <crobinso@xxxxxxxxxx> wrote:
>On 01/27/2014 02:48 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
>>
>>
>> Chen Hanxiao (2):
>> virt-install: add support for option "--cpu host-model-basic"
>> man: update virt-intall man page for option "--cpu host-model-basic"
>>
>> man/virt-install.pod | 5 +++++
>> virtinst/cli.py | 3 +++
>> 2 files changed, 8 insertions(+)
>>
>
>Idea and code look fine, but I don't like the name 'host-model-basic'. How
>about 'host-model-only' or 'host-model-name' ?
I think 'host-model-only' would be better.
>
>Also, please squash the two patches together, for small option additions we
>should just commit tests, docs, and code all together in one patch.
>
I'll squash them together with v2 patch.
Thanks for your advice.
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
