On Sat, Jan 25, 2014 at 12:43:52PM -0500, Cole Robinson wrote: > On 01/24/2014 09:13 AM, Giuseppe Scrivano wrote: > > This series adds libosinfo support to virt-manager, that is used to > > populate the OS list instead of maintaining it in osdict.py. > > > > This new version doesn't manually add any OS that is not already > > present in libosinfo (now all the missing pieces are in libosinfo > > upstream: 9d41ab02fc3a1a8897ceacba8a653313c72c8efb). > > > > If you are going to test it, please use the upstream libosinfo version. > > > > Giuseppe Scrivano (7): > > virtinstall: allow to redefine typename in _OSVariant > > virtinstall: read OSes information from libosinfo > > virtinstall: add some quirks > > virt-manager: add dependency to libosinfo > > tests: fix to not fail with libosinfo > > osdict: expose libosinfo recommended resources for an OS > > virtManager: by default use the recommended resources to run an OS > > > > tests/misc.py | 3 +- > > virt-manager.spec.in | 1 + > > virtManager/create.py | 24 ++- > > virtinst/osdict.py | 438 +++++++++++++++++++++++++++++++++++++------------ > > virtinst/urlfetcher.py | 2 +- > > 5 files changed, 357 insertions(+), 111 deletions(-) > > > > Thanks for this. Patches look fine to me minus some minor comments. > > Though when I run this on stock f20, which seems to have libosinfo-0.2.8, > virt-manager just segfaults. I think it will be quite common for a while that > people try to run upstream virt-manager but won't have the latest required > libosinfo version on their machine. Can you add a check somewhere that will > detect if libosinfo isn't new enough, and provide a helpful message to the > user, then gracefully exit? > > Also, we can probably drop the 'virt-install --os-variant list' handling, and > point man page/help output to whatever the libosinfo equivalent is. $ osinfo-query os Short ID | Name | Version | ID ----------------------+----------------------------------------------------+----------+----------------------------------------- altlinux1.0 | Mandrake RE Spring 2001 | 1.0 | http://altlinux.org/altlinux/1.0 altlinux2.0 | ALT Linux 2.0 | 2.0 | http://altlinux.org/altlinux/2.0 altlinux2.2 | ALT Linux 2.2 | 2.2 | http://altlinux.org/altlinux/2.2 altlinux2.4 | ALT Linux 2.4 | 2.4 | http://altlinux.org/altlinux/2.4 altlinux3.0 | ALT Linux 3.0 | 3.0 | http://altlinux.org/altlinux/3.0 altlinux4.0 | ALT Linux 4.0 | 4.0 | http://altlinux.org/altlinux/4.0 altlinux4.1 | ALT Linux 4.1 | 4.1 | http://altlinux.org/altlinux/4.1 altlinux5 | ALT Linux 5.0.0 Ark | 5.0 | http://altlinux.org/altlinux/5 altlinux6 | ALT Linux 6.0.0 Centaurus | 6.0 | http://altlinux.org/altlinux/6 altlinux7 | ALT Linux 7.0.0 Centaurus | 7.0 | http://altlinux.org/altlinux/7 centos6.0 | CentOS 6.0 | 6.0 | http://centos.org/centos/6.0 centos6.1 | CentOS 6.1 | 6.1 | http://centos.org/centos/6.1 centos6.2 | CentOS 6.2 | 6.2 | http://centos.org/centos/6.2 centos6.3 | CentOS 6.3 | 6.3 | http://centos.org/centos/6.3 centos6.4 | CentOS 6.4 | 6.4 | http://centos.org/centos/6.4 debian1.0 | Debian Buzz | 1.1 | http://debian.org/debian/1.0 ...snip... Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
