> -----Original Message----- > From: Cole Robinson [mailto:crobinso@xxxxxxxxxx] > Sent: Wednesday, January 22, 2014 1:21 AM > >>> > >>> self.widget("controller-type").set_text(type_label) > >>> combo = self.widget("controller-model") > >>> - uihelpers.set_grid_row_visible(combo, is_usb) > >>> + uihelpers.set_grid_row_visible(combo, True) > >>> > >>> model = combo.get_model() > >>> model.clear() > >>> @@ -3314,6 +3313,9 @@ class vmmDetails(vmmGObjectUI): > >>> model.append(["ich9-ehci1", "USB 2"]) > >>> model.append(["nec-xhci", "USB 3"]) > >>> self.widget("config-remove").set_sensitive(False) > >>> + elif dev.type == virtinst.VirtualController.TYPE_SCSI: > >>> + model.append(["default", "Default"]) > >>> + model.append(["virtio-scsi", "Virtio SCSI"]) > >>> else: > >> > >>If you just do [None, "Default"] here, you don't need to specially handle > >>"default" in domain.py > > > > I did a simple test like: > > > > + model.append([None, "Default"]) > > + model.append(["virtio-scsi", "Virtio SCSI"]) > > > > And keep the rest of codes unchanged. > > > > We could change scsi-controller from "default" to "virtio-scsi", > > > > but failed to change it from "virtio-scsi" to "defalut" > > > > (press 'Apply' button, but nothing happed) > > Hmm, not sure why. But no worries, just leave that "default" part in the next > patch. > OK, I'll keep ["default", "Default"] in the next version and rewrite this patch Thanks > - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
