Re: [virt-manager PATCH] Rename hide_unsupported_rhel_options to stable_defaults and clean-up its usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2014 at 12:55:09PM +0100, Giuseppe Scrivano wrote:
> Martin Kletzander <mkletzan@xxxxxxxxxx> writes:
>
> > There were multiple problems with the setting and usage of
> > hide_unsupported_rhel_options.  Due to the fact that the option has
> > several diferent namings throughout the code, this patch is renaming
> > it to stable_defaults, which basically says what the option does and
> > makes it possible to use it without need for more than one negation
> > (where the old code had up to 4 of them in some places), which also
> > helps understanding it.
> >
> > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
>
> nice idea!  I've tested it and it seems to work correctly for me.
>

Thanks for that.  This patch is very tricky due to some mistakes in
the code taken for granted and so on.  I went through the code many
times to ensure myself I haven't change anything that was not broken
(i.e. change only the broken ones), but one can never be sure, right?
So once again, thanks for testing it.

Martin

Attachment: signature.asc
Description: Digital signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux