Re: [virt-manager PATCH] pylint: Skip hashlib import hackery and remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 20, 2014 at 10:30:25AM -0500, Cole Robinson wrote:
> On 01/20/2014 09:19 AM, Giuseppe Scrivano wrote:
> > Martin Kletzander <mkletzan@xxxxxxxxxx> writes:
> >
> >> hashlib's dynamic import hackery makes pylint very sad since it cannot
> >> realize that the module has sha256 member (just created dynamically),
> >> so let's just make it skip this error.
> >>
> >> Also remove unused variable in virtinst.cli
> >>
> >> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> >> ---
> >>  virtinst/cli.py       | 3 +--
> >>  virtinst/virtimage.py | 4 ++--
> >>  2 files changed, 3 insertions(+), 4 deletions(-)
> >
>
> Newer pylint should be smart enough to avoid that error, but disabling it is
> fine too.
>
> ACK
>

Yep, looks like it, but I was still stuck with 0.28 :( Updated to
1.1.0 (even though it's not in my distro repository anywhere) and this
particular error is OK.  However there are maybe hundreds of different
errors (maybe configuration problem).  However, thanks for having a
look at this, hopefully this will clear up the results after testing
my next patch.

Pushed now,

Martin

Attachment: signature.asc
Description: Digital signature

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list

[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux