On 01/06/2014 03:04 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > --- > ui/addhardware.ui | 76 ++++++++++++++++++++++++++++++++++++++++++++-- > virtManager/addhardware.py | 42 ++++++++++++++++++++++++- > 2 files changed, 115 insertions(+), 3 deletions(-) > A played with this lightly. A few general comments: - UI issues: the labels should be capitalized correctly, left aligned (set xalign to 0), and use underline/mnemonics. - Change the UI name of the device from 'PANIC' to 'Panic Notifier'. Might need to do the same in the other virt-manager patch - What's the point of iobase? When will a user ever want to change it? If it's only rarely used, we might consider dropping the UI field for it. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
