On 01/06/2014 03:04 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > --- > virtinst/__init__.py | 1 + > virtinst/device.py | 4 +++- > virtinst/devicepanic.py | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 48 insertions(+), 1 deletion(-) > create mode 100644 virtinst/devicepanic.py > Thanks for the patches. Code looks fine here, but please also add a test case with this commit: at least some test cases in tests/xmlparse.py and a device add case in tests/xmlconfig.py:testManyDevices. commit 8abcae50733c10a06de394248612aef0e8405c90 has some examples here. - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
