Hey, It seems the patch below was pushed without review. Even for trivial patches (not saying this one is), it would be nice to send them to the mailing list in case people want to review it after the fact. In this case, the patch has several issues: - typo in the commit log (which we can't fix now) - it does not update the .spec files nor the README file which refer to 0.20 - fixing autobuild.sh means more work on fedora side as f20 does not have spice-gtk 0.22 Can we get all pushed patches sent to the mailing list so that we can always have the option of getting code review goodness ? :) Thanks, Christophe From d1c2bc17fa539f1ff58e0d8c10e3743e482fc4de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <marcandre.lureau@xxxxxxxxx> Date: Mon, 16 Dec 2013 18:10:22 +0100 Subject: [virt-viewer] build-sys: require spice-gtk >= 0.22 Require 0.22 fro spice_uuid_to_string() --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index bb0b591..070424c 100644 --- a/configure.ac +++ b/configure.ac @@ -19,7 +19,7 @@ GTK2_REQUIRED="2.18.0" GTK3_REQUIRED="3.0" GTK_VNC1_REQUIRED="0.3.8" GTK_VNC2_REQUIRED="0.4.0" -SPICE_GTK_REQUIRED="0.20" +SPICE_GTK_REQUIRED="0.22" SPICE_PROTOCOL_REQUIRED="0.10.1" AC_MSG_CHECKING([for native Win32]) -- 1.8.4.2
Attachment:
pgpEyhs_zOsMd.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
