Re: [virt-manager PATCH] add RAM filesystems browse support for lxc container

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/2013 12:52 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> 
> LXC container could use in-memory filesystem,
> which do not have source section.
> Currently, virt-manager will complain if
> dev.source is null.
> This patch will fix this issue.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx>
> ---
>  virtManager/details.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 6537466..d55f1cb 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -3304,7 +3304,11 @@ class vmmDetails(vmmGObjectUI):
>  
>          self.widget("fs-wrpolicy").set_text(dev.wrpolicy or _("Default"))
>  
> -        self.widget("fs-source").set_text(dev.source)
> +        if dev.source:
> +            self.widget("fs-source").set_text(dev.source)
> +        else:
> +            self.widget("fs-source").set_text("RAM")
> +
>          self.widget("fs-target").set_text(dev.target)
>          if dev.readonly:
>              self.widget("fs-readonly").set_text("Yes")
> 

Please simplify this to

self.widget("fs-source").set_text(dev.source or _("RAM"))

Thanks,
Cole

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux