On Wed, Nov 13, 2013 at 11:18:25AM +0100, Christophe Fergeau wrote: > virt-viewer currenty builds with gtk+ 2.0 by default. Nowadays, gtk+ 2.0 is > legacy, and this default is inconsistent with spice-gtk which defaults to > gtk+ 3.0. This commit switches the default to gtk+ 3.0 > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index ed0fc91..bb0b591 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -107,12 +107,12 @@ AM_CONDITIONAL([HAVE_LIBVIRT], [test "x$have_libvirt" = "xyes"]) > > AC_MSG_CHECKING([which gtk+ version to compile against]) > AC_ARG_WITH([gtk], > - [AS_HELP_STRING([--with-gtk=2.0|3.0],[which gtk+ version to compile against (default: 2.0)])], > + [AS_HELP_STRING([--with-gtk=2.0|3.0],[which gtk+ version to compile against (default: 3.0)])], > [case "$with_gtk" in > 2.0|3.0) ;; > *) AC_MSG_ERROR([invalid gtk version specified]) ;; > esac], > - [with_gtk=2.0]) > + [with_gtk=3.0]) > AC_MSG_RESULT([$with_gtk]) > > case "$with_gtk" in ACK, GTK-3 has been around long enough now that we can consider it a reasonable default. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
