On 08/07/2013 09:29 PM, Cole Robinson wrote: > On 08/07/2013 09:12 AM, Martin Kletzander wrote: >> Due to all the negations for 'hide-unsupported-rhel-options' option in >> configuration, there was missing 'not' in virt-manager when setting >> relevant self.config variable. This patch changes it the same way as >> in 'virtinst/__init__.py', which is right. >> > > Yeah the negation is weird. If you have a recommendation of simplifying it, > please submit a patch, I'm happy to change it. > I had an idea a while ago, I'll see how it looks and propose something when there's not so much rush. >> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> >> --- >> virt-manager | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/virt-manager b/virt-manager >> index 42779ae..cc506fb 100755 >> --- a/virt-manager >> +++ b/virt-manager >> @@ -244,7 +244,7 @@ def main(): >> >> virtManager.util.running_config = config >> config.default_qemu_user = cliconfig.default_qemu_user >> - config.rhel6_defaults = cliconfig.rhel_enable_unsupported_opts >> + config.rhel6_defaults = not cliconfig.rhel_enable_unsupported_opts >> config.preferred_distros = cliconfig.preferred_distros >> >> config.hv_packages = cliconfig.hv_packages >> > > ACK > Pushed, thanks. Martin _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list