On 07/30/2013 08:03 PM, Giuseppe Scrivano wrote: > Now when the `password' field is empty and `allow empty password' is > selected the password is set to "". > The former behaviour (an empty `password' field unsets the password) > is maintained if the `allow empty password' is not selected. > > Solves: https://bugzilla.redhat.com/show_bug.cgi?id=749718 > > Signed-off-by: Giuseppe Scrivano <gscrivano@xxxxxxx> > --- > ui/vmm-details.ui | 183 +++++++++++++++++++++++++++++-------------------- > virtManager/details.py | 17 ++++- > virtManager/domain.py | 2 +- > 3 files changed, 124 insertions(+), 78 deletions(-) > Code looks good, but I'd like the UI to be a bit different. Rather than Password: <text field> Allow Empty Password: <chkbox> Do: Password: <chkbox> <text field> For graphics devices without a password, the chkbox will be unchecked and the text field inactive/grayed out. If the user wants an empty password, just select the chkbox but don't enter any text, and hit apply. If the user wants to remove any existing password, just unselect the chkbox, and hit apply. I think this will be an improvement over the UI in virt-manager.git while enabling the empty password usecase. Also, please make a similar change to addhardware->graphics. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
