On 07/16/2013 03:52 PM, Cole Robinson wrote: > On 07/16/2013 02:10 AM, Martin Kletzander wrote: >> On 07/15/2013 09:57 PM, Cole Robinson wrote: >>> On 07/15/2013 04:00 AM, Martin Kletzander wrote: >>>> The '--default-graphics' option of 'setup.py configure' only affects >>>> virt-manager, but not virt-install. This should be unified, so this >>>> patch checks whether default_graphics taken from the cli is supported >>>> and uses that option. >>>> >>> >>> ACK >>> >> >> Thanks, pushed, >> > > Looks like it breaks the test suite. The change in cliconfig.py changes the > default if ./setup.py configure was never run, like on a fresh checkout. I > think that bit should be reverted, but we also want to hardcode a default for > this setting in the test suite so the results don't change depending on how > the user configured things. Can probably set it in tests/__init__.py, there's > precedent there. > Oh, shoot. Anyway, I managed to fix that and am sending a patch for that in a second. Thanks, Martin _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
