On 06/24/2013 01:52 PM, Hans de Goede wrote: > Hi, > > On 06/24/2013 12:11 PM, Guannan Ren wrote: >> >> This two patch use spicy-client python binding to add USB redirection >> support in virt-manager if guests use spice viewer. > > Very cool, thanks for working on this. I've done a quick review, mostly > from the usbredir pov rather then a code pov, and there is one thing > missing. > > Now that virt-manager will have a usb-device selection dialog, it > should probably also enable usb autoredirection by setting the > auto-connect property of the UsbDeviceManager to true, this will enable > the "If the virt-viewer window has the current focus and I insert a USB > device, it will be automatically redirected to the guest" behavior > Leonardo is talking about. > > I see that Cole is not necessarily a fan of it. Cole, you should give > this a try, most users love it. In virt-viewer we just always enable > it without any complaints. Alternatively it could be made an option > but I would default it to true. > I wouldn't characterize it as 'not a fan', more as 'fear of future complaints or user confusion'. But my suggestion was to implement things like virt-viewer and add a disable option if people make enough of a stink :) - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
