On 06/05/2013 03:40 PM, lagarcia@xxxxxxxxxxxxxxxxxx wrote: > From: Leonardo Garcia <lagarcia@xxxxxxxxxx> > > --- > data/org.virt-manager.virt-manager.gschema.xml | 6 ++++ > ui/vmm-preferences.ui | 31 ++++++++++++++++++++++++ > virtManager/config.py | 4 +++ > virtManager/preferences.py | 7 +++++ > 4 files changed, 48 insertions(+), 0 deletions(-) > Please separate this change from the second patch, so everything that is needed to delete active VMs is in one patch. I'm fine with allowing users to delete active VMs, but I don't think we need another confirmation item here. What we should do is just show a simple text field warning in the delete dialog, above the storage list, warning that the VM is active and will be forced off before deletion. Then call out to the destroy helper in engine.py which already checks the 'confirm before destroy' preference so we can piggy back on that. The warning should just be a small text field with the caution icon, similar to what we do in the create wizard on the final page if trying to do a PXE install with the default virtual network, or any network which doesn't support PXE. Let me know if I can clarify anything. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
