Excerpts from Daniel P. Berrange's message of 2013-04-11 15:48:59 +0200: > On Thu, Apr 11, 2013 at 02:51:53PM +0200, Marc Fournier wrote: > [...] > IMHO this is uneccesarily complex. Just check for existence of > a 'container' environment varibles in /proc/1/environ, which is > the agreed marker for a container[1], and ignore legacy code > which didn't set that. The cgroups check doesn't add any value > here either. > > Daniel > > [1] http://www.freedesktop.org/wiki/Software/systemd/ContainerInterface Thanks for the review, Daniel ! So if we don't need to take older LXC implementations in account, everything is indeed much simpler :) I wasn't aware of the page you mentioned, but I did notice RHEL6 and upcoming debian 7 both set this "container" environment variable. I was just worried to also catch legacy implementations. I'll post an updated patch(set) to the list in a couple of minutes. Cheers, Marc _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
