On 04/13/2013 03:42 PM, Gene Czarcinski wrote: > OK, lets run this version stuff up the flag pole and see if anyone > salutes. This is the "eat the cake and have it too" version. > > Gene Czarcinski (5): > update __version__ to 0.9.100 for pre-release id > automate @VERSION@ in virt-manager.spec > add user setable version using configure > add option for snapshot-id suffix to __version__ > update spec file to use its version at runtime I haven't looked at the patches themselves, but noticed one thing: > > .gitignore | 1 + > setup.py | 53 ++++- > virt-manager.spec | 612 -------------------------------------------------- > virt-manager.spec.in | 613 +++++++++++++++++++++++++++++++++++++++++++++++++++ This looks like a file rename. If you would do: git config --global diff.renames true then 'git diff' (and thus 'git send-email') will show a much more compact representation of the rename, instead of all lines deleted from the old and all lines added to the new. I also find it easier to review patches with git rename detection enabled, because you can then focus on the 1% of the lines that changed during the rename, instead of the 99% of the lines that moved between files unchanged. Or drop --global if you are worried about interacting with a project that still supports non-git access such as CVS or hg mirroring, but then remember to do it on a per-project basis for any project that uses git exclusively. [Legacy compatibility with non-git projects is the only reason that git doesn't enable this config option by default, but since git rename diffs are so useful, even upstream GNU diff and patch have learned to use them] -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
