On Tue, Mar 26, 2013 at 02:38:59PM +0100, Hans de Goede wrote: > Hi, > > On 03/26/2013 02:33 PM, Marc-André Lureau wrote: > > <snip> > > >ok with that in src/virt-gtk-compat.h? > > > >+#if !GTK_CHECK_VERSION(3, 0, 0) > >+#define gtk_widget_set_realized(widget, val) \ > >+ GTK_WIDGET_SET_FLAGS(widget, GTK_REALIZED) > >+#define gtk_widget_get_realized(widget) \ > >+ GTK_WIDGET_REALIZED(widget) > >+#endif > > Shouldn't the gtk_widget_set_realized macro do something > with its val argument ? > > Maybe only define get_realized since that is the one we > are actually using ? Yup same as Hans. Bonus points if you get rid of the duplicated fallback definitions there are in ovbox.h, but I don't really mind, I'm plenty fine with just get_realized in -compat.h Christophe
Attachment:
pgpCE_mMpmTpp.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
