On Thu, Mar 21, 2013 at 05:23:40PM +0100, Hans de Goede wrote: > Since the sensitivity of the display menu-check-items depends on show_hint, > we need to call virt_viewer_app_update_menu_displays on show_hint change. > > This fixes the following scenario: > 1) Linux guest with upto 4 displays on a single qxl dev > 2) Configure it for 2 displays > 3) Switch to a text-console in the guest (ie send ctrl+alt+F3) > 4) All displays except for disp 1 are now not sensitve in the menu > 5) Switch back to X > 6) The second display in the view->displays menu is still not sensitive This means that in this situation none of the signals where we call virt_viewer_app_update_menu_displays fired, is that intentional? Or is notify::show-hint precisely the signal that is fired in this situation? If this is the case your patch makes total sense to me, ACK Christophe
Attachment:
pgpYV7XtAwdAK.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
