Re: [PATCHv2 2/4] Add virt_viewer_compare_version()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Mon, Mar 11, 2013 at 9:45 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> While I agree with Hans that we don't want to try to handle rc1, a, ...
> there, this code will also choke on versions like 0.18.13-09abc (which
> spice-gtk uses for git snapshots), this might be needed at some point

This is not a general version comparison function. Nevertheless, it is
trivial to drop the final -suffix before comparison.

I don't think it's a good idea to compare against each dependency. We
should rather bump version requirement at virt-viewer level, and be
done with one version check.

-- 
Marc-André Lureau

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux