On 02/06/2013 09:57 PM, Cole Robinson wrote: > On 02/05/2013 06:28 AM, Martin Kletzander wrote: >> virt-install already supports relabeling, but virt-manager doesn't and >> in some cases, this can cause problems, for example when switching to >> dynamic labeling with the relabeling turned off. I took the approach >> of allowing the user to choose, with safe fallbacks to defaults. >> >> Deals also with this: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=907390 >> --- >> Sorry for thelask hunk (space at the end), but I thought it its worthless >> to send it in a separate patch. >> --- >> src/virtManager/details.py | 24 ++++++++++++++++++------ >> src/virtManager/domain.py | 24 +++++++++++++++++++----- >> src/vmm-details.ui | 18 +++++++++++++++++- >> 3 files changed, 54 insertions(+), 12 deletions(-) > > Thanks Martin, pushed now. > > Though once the gtk3 conversion is upstream I'm probably going to drop all the > labeling bits from the UI. It really should be messed with rarely enough that > we can just tell users to do it on the command line. > Makes sense, thanks for the info. Martin _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
