On Mon, Dec 17, 2012 at 8:26 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Mon, Dec 17, 2012 at 08:10:16AM -0200, Fabiano Fidêncio wrote: >> On Mon, Dec 17, 2012 at 7:47 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: >> > On Mon, Dec 17, 2012 at 07:24:34AM -0200, Fabiano Fidêncio wrote: >> >> Annotations for: >> >> - osinfo_install_script_generate_finish() >> >> - osinfo_install_script_generate_output_finish() >> > >> > and osinfo_media_get_os and osinfo_media_set_languages (thanks for adding >> > these, I had totally overlooked that). Did you get warnings about the >> > missing _set_languages annotation? the symbol is not exported. >> >> Yes, I did. >> I'm passing --warn-all to g-ir-scanner.I'm also getting these 2 >> warnings that I have no clue how to fix: http://pastebin.com/KPVBCzCe > > I think these are just small typos: And this is the proof I need to sleep :) Please, commit your patch (it's trivial) and thank you :) > > diff --git a/osinfo/osinfo_db.c b/osinfo/osinfo_db.c > index 024f181..2015106 100644 > --- a/osinfo/osinfo_db.c > +++ b/osinfo/osinfo_db.c > @@ -397,7 +397,7 @@ OsinfoDeploymentList > *osinfo_db_get_deployment_list(OsinfoDb *db) > > > /** > - * osinfo_db_get_install_datamap_list: > + * osinfo_db_get_datamap_list: > * @db: the database > * > * Returns: (transfer full): the list of install datamaps > diff --git a/osinfo/osinfo_list.c b/osinfo/osinfo_list.c > index 657dace..25716c9 100644 > --- a/osinfo/osinfo_list.c > +++ b/osinfo/osinfo_list.c > @@ -465,7 +465,7 @@ OsinfoList *osinfo_list_new_intersection(OsinfoList > *sourceOne, > } > > /** > - * osinfo_new_union: > + * osinfo_list_new_union: > * @sourceOne: the first list to copy > * @sourceTwo: the second list to copy > * > > Christophe Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
