Series looks good to me, one minor comment in patch 4. Regarding certificate passing, do we have a multiline ----BEGIN CERTIFICATE---- -----END CERTIFICATE----- block in the ini-like file? Christophe On Tue, Nov 27, 2012 at 08:15:04PM +0100, Marc-André Lureau wrote: > Hi, > > RHEVM portal sets up remote-viewer using the Spice Controller [1] (a > browser applet will spawn the client, and connect to it to communicate > connection details and other messages) > > In order to avoid the need for an extra communication channel route > and various browser applets, we could use a simple text file > containing all the necessary informations, allowing easier portability > and testing. > > This file is not specific to Spice. It could be used as well to start > VNC connections, and configure the client. > > We keep the RHEVM/Spice format for description of hotkeys, to avoid > breaking exisiting configuration. Eventually, new fields could be > added later with the more conveninent Gtk accel format instead. > > Since v1: > - address most reviews from Christophe > - switch PEM CA key from base64 to plain string > - explained why a mime type is needed for recent handling > > [1] http://spice-space.org/page/Whiteboard/ControllerProtocol > > Marc-André Lureau (7): > session: add virt_viewer_session_mime_type() > recent: get mime type from session > Move spice_hotkey_to_gtk_accelerator() to util > Add VirtViewerFile > Add VirtViewerSession:file property > spice: learn to connect from file > remote-viewer: learn to connect from file > > src/Makefile.am | 1 + > src/remote-viewer-main.c | 10 +- > src/remote-viewer.c | 139 ++----- > src/virt-viewer-file.c | 797 ++++++++++++++++++++++++++++++++++++++++ > src/virt-viewer-file.h | 102 +++++ > src/virt-viewer-session-spice.c | 98 ++++- > src/virt-viewer-session-vnc.c | 6 + > src/virt-viewer-session.c | 51 +++ > src/virt-viewer-session.h | 5 + > src/virt-viewer-util.c | 113 ++++++ > src/virt-viewer-util.h | 2 + > 11 files changed, 1202 insertions(+), 122 deletions(-) > create mode 100644 src/virt-viewer-file.c > create mode 100644 src/virt-viewer-file.h > > -- > 1.7.11.7 > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
pgpwEohlJvDAD.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
