On Tue, Oct 30, 2012 at 4:18 PM, Michal Privoznik <mprivozn@xxxxxxxxxx> wrote: > On 30.10.2012 14:52, Zeeshan Ali (Khattak) wrote: > diff --git a/cfg.mk b/cfg.mk > index 6aaa394..b90abed 100644 > --- a/cfg.mk > +++ b/cfg.mk > @@ -134,8 +134,8 @@ exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch] > > exclude_file_name_regexp--sc_prohibit_strcmp = ^*/*.[ch] > > -exclude_file_name_regexp--sc_require_config_h = python/libvirt-glib.c > -exclude_file_name_regexp--sc_require_config_h_first = python/libvirt-glib.c > +exclude_file_name_regexp--sc_require_osinfo_priv_h = python/libvirt-glib.c > +exclude_file_name_regexp--sc_require_osinfo_priv_h_first = python/libvirt-glib.c > > exclude_file_name_regexp--sc_trailing_blank = ^test/isodata/.*|docs/object-model.fig > > diff --git a/maint.mk b/maint.mk > index de7a303..6349d7e 100644 > --- a/maint.mk > +++ b/maint.mk > @@ -432,29 +432,29 @@ sc_prohibit_have_config_h: > halt='found use of HAVE''_CONFIG_H; remove' \ > $(_sc_search_regexp) > > -# Nearly all .c files must include <config.h>. However, we also permit this > +# Nearly all .c files must include <osinfo_priv.h>. However, we also permit this > # via inclusion of a package-specific header, if cfg.mk specified one. > -# config_h_header must be suitable for grep -E. The 'However' part of the original comment here makes me wonder if we need such an intrusive patch? -- Regards, Zeeshan Ali (Khattak) FSF member#5124
