On Mon, Oct 29, 2012 at 11:08 PM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 10/29/2012 08:43 AM, Zeeshan Ali (Khattak) wrote: >> From: Eric Blake <eblake@xxxxxxxxxx> >> >> AUTHORS: Add myself. >> --- >> AUTHORS | 1 + >> maint.mk | 402 ++++++++++++++++++++++++++++++++++++++++++--------------------- >> 2 files changed, 273 insertions(+), 130 deletions(-) > > ACK. > > However, a minor heads-up: gnulib is contemplating a minor patch to > maint.mk that would rename the cfg.mk variable that you use: > > https://lists.gnu.org/archive/html/bug-gnulib/2012-10/msg00095.html > - grep -E -l '$(translation-markers)' $$files \ > + grep -E -l '$(_gl_translatable_string_re)' $$files \ > > It might be worth holding off 24 hours until Jim actually commits that > gnulib change, Oops, I already pushed after Michal's ACK. Should have waited for your ACK too as I asked you to look at the patches earlier. > and then synchronize to that version of maint.mk, rather > than landing on a version of maint.mk from a 3-day window, and where the > next time anyone updates maint.mk they get a surprise if they aren't > aware of the need to rename the cfg.mk variable. We'll get an error from `make syntax-check` when that happens, right? -- Regards, Zeeshan Ali (Khattak) FSF member#5124
