Eric Blake <eblake@xxxxxxxxxx> on Mon, 2012/10/22 06:53:
> On 10/21/2012 10:05 AM, Christian Hesse wrote:
> > ---
>
> > +++ b/tests/test-baremetal.sh
> > @@ -17,18 +17,18 @@
> >
> > root=tests/baremetal
> >
> > -output="$(./virt-what --test-root=$root 2>&1)"
> > +output="$(./virt-what --test-root=${root} 2>&1)"
>
> Why? This is cosmetic only, and serves only to require additional
> typing. I don't see any correctness changes in this patch.
You are right, this is just cosmetic changes (except some cases we do not
meet here). But I think it makes the code clearer and prevents some potential
errors.
Feel free it ignore this, was just a suggestion. ;)
--
Schoene Gruesse
Chris
O< ascii ribbon campaign
stop html mail - www.asciiribbon.org
