On Tue, Oct 9, 2012 at 10:36 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> On Mon, Oct 08, 2012 at 07:40:56PM +0300, Zeeshan Ali (Khattak) wrote:
>> +
>> + /**
>> + * OsinfoMedia::installer-reboots:
>> + *
>> + * If media is an installer, this property indicates the number of reboots
>> + * the installer takes before installation is complete.
>> + *
>> + * This property is not applicable to media that has no installer. You can
>> + * use #osinfo_media_get_installer (or OsinfoMedia::installer) to check
>> + * that.
>> + *
>> + * Warning: Some media allow you to install from live sessions, in which
>> + * case number of reboots *alone* is not a reliable method for tracking
>> + * installation.
>> + */
>> + pspec = g_param_spec_int ("installer-reboots",
>> + "InstallerReboots",
>> + "Number of installer reboots",
>> + G_MININT,
>
> The actual minimum value is -1 (or 0 ?)
Yeah.
>> + G_MAXINT,
>> + 1 /* default value */,
>> + G_PARAM_READWRITE |
>> + G_PARAM_CONSTRUCT | /* to set default value */
>
> I don't think we need it to be set during construction, do we?
This is more a generic question applying to all the other props too:
Do we want apps to be able to *easily* set these props, i-e encourage
it?
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
