On Mon, Oct 8, 2012 at 5:05 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > On Mon, Oct 08, 2012 at 03:58:06PM +0200, Christophe Fergeau wrote: >> From: David Zeuthen <davidz@xxxxxxxxxx> >> >> The udev rules for detecting OS'es are too complicated and they also don't >> work when detecting OS'es on e.g. a loop device. For example, the stuff >> about DISK_MEDIA_CHANGE is kinda wrong. >> >> The latter is pretty annoying as the default action in F18 for an .ISO file >> is to loopback mount it - as a result the user is presented with "Open with >> Files" instead of "Open with Boxes". >> >> Fixes rhbz#863468 >> --- >> data/95-osinfo.rules.in | 26 ++------------------------ >> 1 file changed, 2 insertions(+), 24 deletions(-) > > I don't particularly understand the differences in this, but if that's > what David Z is recommending & it has been tested to work, then it gets > my ACK. Yeah, I think this should be tested and we shouldn't just blindly trust David Z (no offense). I tested without the patch here and loopback devices work exactly how they should: Double click on an ISO in nautilus and the popup dialog should say "open with Boxes" rather than "open with Files". -- Regards, Zeeshan Ali (Khattak) FSF member#5124
