On Mon, Oct 01, 2012 at 06:26:06PM +0200, Christophe Fergeau wrote: > Commit 2201a5a was supposed to free a SPICE ticket leak, but it's > actually introducing a double-free as the SPICE ticket is > unconditionally freed at the end of > virt_viewer_session_spice_main_channel_event > --- > src/virt-viewer-session-spice.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c > index 870bd87..cc20ad8 100644 > --- a/src/virt-viewer-session-spice.c > +++ b/src/virt-viewer-session-spice.c > @@ -354,7 +354,6 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED > gboolean openfd; > > g_object_set(self->priv->session, "password", password, NULL); > - g_free(password); > g_object_get(self->priv->session, "client-sockets", &openfd, NULL); > > if (openfd) ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
