On Mon, Aug 27, 2012 at 8:14 PM, Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx> wrote: > On Tue, Aug 28, 2012 at 1:54 AM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >> On Mon, Aug 27, 2012 at 7:43 PM, Zeeshan Ali (Khattak) >> <zeeshanak@xxxxxxxxx> wrote: >>> On Tue, Aug 28, 2012 at 12:57 AM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >>>> On Mon, Aug 27, 2012 at 6:03 PM, Zeeshan Ali (Khattak) >>>> <zeeshanak@xxxxxxxxx> wrote: >>>>> On Sun, Aug 26, 2012 at 11:50 AM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >>>>>> Add a new entity called OsinfoInstallScriptAvatar to help the creation >>>>>> of an Avatar file for an install script. If avatar entity needs to be >>>>>> set, just add, in the .xml's script file: >>>>>> <avatar> >>>>>> <image-type>...</image-type> >>>>>> <extension>...</extension> >>>>>> <alpha>...</alpha> >>>>>> <width>...</width> >>>>>> <height>...</height> >>>>>> </avatar> >>>>> >>>>> I don't quit follow one major thing here: What is the direction of the >>>>> OsinfoInstallScriptAvatar? Is app setting it on libosinfo or app >>>>> getting it from libosinfo? How would a typical usage look like? >>>> >>>> App is getting it from libosinfo. With this entity, we can drop >>>> AvatarFormat boxes' class and get this info from install-script. >>> >>> Ah ok so its all about script telling app that if it needs to add a >>> user avatar, which format it needs to be in? If so, how does app know >>> which filename to use with avatar? >> >> How is it done in gnome-boxes? > > You are writing the Boxes patch so you tell me. :) If you are asking > about existing code, it simply uses the username + extention as the > filename. We'll need a way to create/get avatar filename for/to the > application. My idea would be to treat this similar to how we deal > with windows XP's .cmd and .reg files. They are not scripts either but > we treat them as such. > > BTW, how does this patch work with your avatar releted code in commit 1d9822ae ? Hmmm. Looks like we need to improve OsinfoInstallScriptAvatar to support, beyond what is supported: - mount point - source path - destination path - disk format (what is being done in the XSL) - filename With these stuffs, I think we can replace all "hardcoded" information about avatar. What do you think? > > > -- > Regards, > > Zeeshan Ali (Khattak) > FSF member#5124 Best Regards, -- Fabiano Fidêncio
