On 07/19/2012 03:54 PM, Eric Blake wrote: > On 07/19/2012 01:26 PM, Cole Robinson wrote: >>> #!/bin/sh >>> >>> -exec /usr/bin/python "::PYTHONDIR::/::PACKAGE::.py" "$@" >>> +exec python "::PYTHONDIR::/::PACKAGE::.py" "$@" >> >> One instance was missing, so I fixed that, added some more details, and pushed: >> >> http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=30282a17091014ba5a96d20f4260df55779933c4 > >> >> The change was originally made for unknown reasons: it was requested >> through a RHEL bug that didn't have any justification and I just changed >> it in ignorance: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=708181 >> >>> How reproducible: >> Always, if /usr/bin is removed off $PATH or if a different/custom Python release is placed on another directory and this directory preceeds /usr/bin in $PATH. > > Actually, calling the first 'python' on PATH _is_ potentially > problematic, if you mix more than one python stack on your system. It > may mean that we need a ./configure --with-python=/path/to/python, then > install the tools with a hard-coded substitution to the absolute path > passed at configure time instead of the use of env to run the first > python on PATH. But let's not worry about that unless someone actually > complains that it broke their setup. > Is that any different from /usr/bin/env python though, the change libvirt made? - Cole
