Re: [PATCH virt-viewer 13/19] Number display starting from 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2012 at 01:16:19PM +0200, Marc-André Lureau wrote:
> On Tue, Jul 17, 2012 at 11:46 AM, Christophe Fergeau
> <cfergeau@xxxxxxxxxx> wrote:
> > Why? To match the window subtitle? Please add this to the commit log.
> 
> It just is more user friendly, no? I think human start counting from 1
> in general.

I don't disagree with the change, just curious as to why it's needed since
the commit log doesn't mention it.

> 
> > Id add a +1 as well to
> > DEBUG_LOG("Remove window %d %p", nth, win);
> > and
> > DEBUG_LOG("Insert window %d %p", nth, win);
> 
> However, this is not meant to be user friendly, but rather developper
> friendly, so we should just print the value of these variable, imho

This means that when the GUI talks about display 1 and 2, and the debug log
talks about window 1, you have to know it's really about display 2, imo
this is not developer friendly.

Christophe

Attachment: pgp1dJiH2r8hQ.pgp
Description: PGP signature


[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux