On Tue, Jul 17, 2012 at 11:42 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Mon, Jul 16, 2012 at 06:57:46PM +0200, Marc-André Lureau wrote: >> This flag will help to track wether the display has been > > whether > >> removed/closed and whether it have a really a valid display. > > the part starting at "whether" needs fixing. "Whether it really has a valid > display" ? > >> >> Ready in contrast, is used to "hide" temporarily the display (when >> starting or redrawing the display, to avoid artifacts) >> --- >> src/virt-viewer-app.c | 15 +++++++++------ >> src/virt-viewer-display-spice.c | 20 ++++++++++++++++++++ >> src/virt-viewer-display.c | 15 +++++++++++++++ >> src/virt-viewer-display.h | 2 ++ >> src/virt-viewer-window.c | 12 ++++++++++++ >> 5 files changed, 58 insertions(+), 6 deletions(-) >> >> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c >> index e5c674a..f581531 100644 >> --- a/src/virt-viewer-app.c >> +++ b/src/virt-viewer-app.c >> @@ -611,7 +611,8 @@ display_show_hint(VirtViewerDisplay *display, >> { >> VirtViewerApp *self; >> VirtViewerNotebook *nb = virt_viewer_window_get_notebook(win); >> - gint nth, hint; >> + gint nth; >> + guint hint; > > Doesn't this change belong to the patch turning 'hint' into a bitfield? > You are right, rebased with the spelling fixes. thanks -- Marc-André Lureau