Re: [PATCH virt-viewer 06/19] Turn display:show-hint into flags type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2012 at 10:57 AM, Christophe Fergeau
<cfergeau@xxxxxxxxxx> wrote:
> I would have kept HINT_HIDE as the flag name as it's more
> expressive than _READY imo. Looks good either way.

"HIDE" isn't necessarily 0 anymore, there will be a DISABLED flag in a
following patch. Now that you say it, it could have been "ENABLED"
flag instead, so 0 would still map to !READY && !ENABLED, but I prefer
to DISABLED, since this is the exception, and we might had more flags
in the future, making 0 hard to keep meaningful perhaps.

-- 
Marc-André Lureau


[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux