On Wed, Jun 13, 2012 at 11:39:59AM +0100, Daniel P. Berrange wrote: > On Mon, Jun 11, 2012 at 11:23:01PM -0300, Fabiano Fidêncio wrote: > > These patches are a set of little corrections and some improvements in > > install-script stuffs (so, it's based on danpb's branch dedicated to > > install-script), allowing, then, Gnome Boxes to drop current schema > > to do unattended installations in favor to use this install-script API. > > > > As talked with danpb in #boxes, the whole serie is being send (some of > > them resend) to facilitate the review. > > Thanks, overall I think this is very good work. My main concern is > around trying to remove some of the OS-specific information that > apps or libosinfo code stills need to know (eg image file names, > and script filenames, etc). What you've done should be fairly > easily adaptable to cope with this. I have pushed the first 7 of your patches to my staging branch: https://gitorious.org/~berrange/virt-tools/berrange-libosinfo so you don't need to repost those in the future. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
