On Fri, Jun 08, 2012 at 05:52:47PM +0200, Christophe Fergeau wrote: > On Fri, Jun 08, 2012 at 04:42:39PM +0100, Daniel P. Berrange wrote: > > On Fri, Jun 08, 2012 at 05:38:32PM +0200, Christophe Fergeau wrote: > > > From: Eric Blake <eblake@xxxxxxxxxx> > > > > > > glibc 2.15 (on Fedora 17) coupled with explicit disabling of > > > optimization during development dies a painful death: > > > > > > In file included from /usr/include/limits.h:27:0, > > > from /usr/lib/gcc/x86_64-redhat-linux/4.7.0/include/limits.h:169,. > > > from /usr/lib/gcc/x86_64-redhat-linux/4.7.0/include/syslimits.h:7, > > > from /usr/lib/gcc/x86_64-redhat-linux/4.7.0/include/limits.h:34, > > > from util/bitmap.c:26: > > > /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] > > > cc1: all warnings being treated as errors > > > > > > Work around this by only conditionally defining _FORTIFY_SOURCE, > > > in the case where glibc can actually use it. The trick is using > > > AH_VERBATIM instead of AC_DEFINE. > > > > > > * m4/libosinfo-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): Squelch > > > _FORTIFY_SOURCE when needed to avoid glibc #warnings. > > > > > > s/LIBVIRT/LIBOSINFO/ > > Ah yeah I copied and pasted the libvirt log. Regarding patch attribution, > since I copied and pasted a patch from Eric and used his log, I made him > the author of this commit. I don't know if this is proper practice, or if I > should set myself as the author, and indicate in the log that this is all > Eric's work. Is there a preferred way of handling such situations? In this case, since it is pretty much a straight copy, I think you were correct in leaving Eric as the author and yourself as committer. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
