On 05/18/2012 11:41 AM, Daniel P. Berrange wrote: > On Mon, May 14, 2012 at 02:24:56PM +0100, Daniel P. Berrange wrote: >> Still todo >> >> - Rip out all DBus stuff & make vmmEngine class inherit GtkApplication >> which provides unique support & DBus method handling >> - Switch to use LibvirtGConfig & LibvirtGObject for libvirt interaction >> - Possibly switch to Python 3 too ? >> - Figure out why GNOME keyring is missing Introspection support >> >> My suggestion is that the standalone GIT repo for virt-install >> only live on as a support branch for legacy platforms. >> >> A stable-0.9 branch of virt-manager can be kept for legacy PyGtk2 >> based virt-manager releases. >> >> The virt-manager master branch should exclusively use GObject >> inspection and ideally Python3 and contain both the virt-manager >> and virt-install codebases in one since they are intimately >> related to each other & using separate GIT repos has needlessly >> complicated life for everyone. > > I have now done alot more work on this all, including merging the > virtinst code. > > The source code layout is now thus: > > * All the python programs: > > src/virt-manager.in > src/virt-manager-tui.in > src/virt-install > src/virt-image > src/virt-clone > src/virt-convert > > * What used to be the virtinst/ APIs > > src/virtManager/installer/*.py > > * What used to be the virtconv APIs > > src/virtManager/convertor/*.py > > * What used to be the virtManagerTui APIs > > src/virtManager/newt/*.py > > * Any API which uses the Gtk library > > src/virtManager/gtk/*.py > > * Remaining code shared between GTK & Newt UIs > > src/virtManager/*.py > > The test suite from virtinst is in tests/ as before. > > Due to splicing the history of python-virtinst into the virt-manager > GIT repository, it isn't practical to git send-email this patch > series (unless you want to receive an email flood with every single > previous virtinst commit :-). So I have prepared a branch with the > code > > https://gitorious.org/~berrange/virt-tools/virt-manager-staging/commits/gobject > > In terms of RPMS we get: > > virt-manager - The GTK frontend & virtManager.gtk modules > virt-manager-tui - The Newt frontend & virtManger.newt modules > virt-manager-common - virtManager.installer, virtManager.convertor > and virtManager modules. Also PO files > virt-install - The text based scripts (obsoletes/provides python-virtinst) > Wow, thanks a bunch, this is awesome. I haven't really looked at the code but that plan sounds great. I'm going to shoot for integrating later this or next week, once I wrap my head around the whole thing. Thanks, Cole
