On Wed, Apr 25, 2012 at 05:40:43PM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > We currently record a version number against any product (ie OS > or Hypervisor). The data we are recording against Windows OS > though is not actually an OS version, rather it is the Windows > kernel version. This becomes clear when you wonder why both > Vista and Win2k8 show the same version number - they share > the same kernel, but they are obviously different versions of > the Windows OS > > This introduces an explicit 'kernel-version' property against > OS objects, and adjusts the windows metadata to use this. > @@ -621,7 +629,8 @@ > <os id="http://microsoft.com/win/7";> > <short-id>win7</short-id> > <name>Microsoft Windows 7</name> > - <version>6.1</version> > + <version>7</version> > + <kernel-version>6.1</kernel-version> > <vendor>Microsoft Corporation</vendor> > <family>winnt</family> > <distro>win</distro> The problem is that your original <version> is buggy. Windows "7" isn't version 7, it's version 6.1, despite what the marketing name would have you believe. (That's like saying that Windows 2008 is version 2008). BTW you also need to distinguish between windows "Client" and "Server" product variants (cf. guestfs_inspect_get_product_variant). It would have been a good idea to use the same scheme as libguestfs which already solved this problem thoroughly and has been battle-tested in production with virt-v2v ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v
