Hi,
On 03/30/2012 01:37 PM, Marc-André Lureau wrote:
On Fri, Mar 30, 2012 at 8:38 AM, Hans de Goede<hdegoede@xxxxxxxxxx> wrote:
Looks good, ack.
One remark though (just a remark as the behavior is
from before this test). Wouldn't it be better to error
out when g_strv_length(args) != 1, rather then showing
the connection dialog as if no args were given?
You mean if g_strv_length(args)> 1, error out? Yes, definetely,
something like that?
if (!args || g_strv_length(args) == 0) {
if (connect_dialog(&uri) != 0)
goto cleanup;
} else if (g_strv_length(args)> 1) {
g_printerr(_("Error: you must specify a single URI\n"));
} else {
uri = g_strdup(args[0]);
}
Yes that is exactly what I meant.
Regards,
Hans
