Re: [PATCH 1/4] virt-viewer-window: Remove useless tests for priv->window != NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 5, 2012 at 4:22 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> priv->window gets set on init and never unset, so there is no need to check
> for it.

It's remaining code from the browser plugin support, which has been
broken for a long time.. if you continue in this direction, you'll
probably end up removing all related code.. instead, I think we should
try to keep in mind that a window may not always be available etc.. At
least, that's what we tried to do I think..

-- 
Marc-André Lureau


[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux