On Wed, Feb 29, 2012 at 12:55:30AM +0200, Zeeshan Ali (Khattak) wrote: > On Tue, Feb 28, 2012 at 5:26 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > > > This introduces two new objects > > > > - OsinfoInstallConfig - stores configuration parameters which get > > substituted into the install script template. > > - OsinfoInstallScript - provides a template and the mechanism for > > turning it into an install script using XSLT > > Good stuff! Hard to digest as its a big patch so I might be missing > something obvious here but doesn't this assume the install script to > be always in XML format (which is not true for actually most OSs)? No, XSLT can output plain text data just fine - see the later patches which already do this for Fedora and Windows SIF files > > +#define OSINFO_INSTALL_CONFIG_PROP_L10N_TIMEZONE "l10n-timezone" > > +#define OSINFO_INSTALL_CONFIG_PROP_L10N_LANGUAGE "l10n-language" > > +#define OSINFO_INSTALL_CONFIG_PROP_L10N_KEYBOARD "l10n-keyboard" > > Is the 'l10n' really needed in the name? "Localization language" > sounds wrong/weird to me. I just want a way to group together entries that are related to the user's location/local settings. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
