On Mon, Feb 20, 2012 at 08:56:16PM +0100, Marc-André Lureau wrote: > On Wed, Feb 15, 2012 at 1:42 AM, Marc-André Lureau > <marcandre.lureau@xxxxxxxxx> wrote: > > On Wed, Feb 15, 2012 at 1:29 AM, Marc-André Lureau > > <marcandre.lureau@xxxxxxxxx> wrote: > >> Gtk+ requirement bump to 2.16 is supported by RHEL5 > >> (needed for various accelgroup code). > > > > That's actually incorrect. I knew I had to double check that. > > I worked on a patch to support < gtk 2.14 for the part I added, and I > figured we actually use symbols from 2.18: > > virt-viewer-app.c: In function 'count_window_visible': > virt-viewer-app.c:220: warning: implicit declaration of function > 'gtk_widget_get_visible' > virt-viewer-app.c:220: warning: nested extern declaration of > 'gtk_widget_get_visible' > virt-viewer-app.c: In function 'virt_viewer_app_bell': > virt-viewer-app.c:888: warning: implicit declaration of function > 'gtk_widget_get_window' > virt-viewer-app.c:888: warning: nested extern declaration of > 'gtk_widget_get_window' > virt-viewer-app.c:888: warning: passing argument 1 of > 'gdk_window_beep' makes pointer from integer without a cast > > > Should we just bump gtk deps to 2.18? Yep, that's fine with me. RHEL-6 has 2.18.9, and that is the oldest distro I'm really targetting now. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
