On Tue, Feb 21, 2012 at 10:43 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > On Tue, Feb 21, 2012 at 07:53:03PM +0200, Zeeshan Ali (Khattak) wrote: >> On Tue, Feb 21, 2012 at 3:50 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: >> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> >> >> ACK except for: >> >> > @@ -279,13 +310,13 @@ >> > >> > <media arch="i386"> >> > <iso> >> > - <volume-id>.*G.*RMC.*</volume-id> >> > + <volume-id>GRMCULFRER</volume-id> >> > <publisher-id>MICROSOFT CORPORATION</publisher-id> >> > </iso> >> > </media> >> > <media arch="x86_64"> >> > <iso> >> > - <volume-id>.*G.*RMC.*X.*</volume-id> >> > + <volume-id>GRMCULXFRER</volume-id> >> > <publisher-id>MICROSOFT CORPORATION</publisher-id> >> >> Are you sure about making these volume IDs more specific rather than generic? > > As we've seen, the Windows' ISOs volume IDs are rather bizarre. I think > that using a very generic regex runs a risk of matching bad ISOs. So my > idea is that we should only use precise volume ID matches. To counterbalance > this, my intention is to download all possible ISOs from MSDN, so we can > discover the full set of valid volume IDs & expand the strict matches. OK, but keep in mind that volume IDs (seem to) differ with region/country sometimes. The value you put there now will not match the volume-id of the ISO I have: GSP1RMCPRXFRER_EN_DVD. :) Also IIRC I changed that value to be more generic when matching didn't work for someone (Christophe?). -- Regards, Zeeshan Ali (Khattak) FSF member#5124
