Re: [PATCH 2/2] Implement SPICE desktop resizing that takes account of zoom level

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 7, 2012 at 6:10 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
> +        if (self->priv->main_channel != NULL)
> +            return;
> +        self->priv->main_channel = g_object_ref(channel);

The main channel is destroyed and recreated when reconnecting to use TLS.

It is better to use a weak reference also to be sure the channel is
destroyed when the connection is gone. Otherwise, there is some extra
cleanup to do on the client side iirc.

-- 
Marc-André Lureau


[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux