On Fri, Jan 27, 2012 at 02:51:35PM +0100, Marc-André Lureau wrote: > Using intltool macro only causes build issues on exotic platforms, > such as MinGW. > > As long as this bug isn't fixed, we should use AM_GLIB_GNU_GETTEXT > https://bugs.launchpad.net/intltool/+bug/398571 > --- > configure.ac | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 0737332..d5988b3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -32,6 +32,7 @@ GETTEXT_PACKAGE=virt-viewer > AC_SUBST(GETTEXT_PACKAGE) > AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [GETTEXT package name]) > > +AM_GLIB_GNU_GETTEXT > IT_PROG_INTLTOOL([0.35.0]) NB this partially reverts 3473c4bb49adc0caca58dc1a8b6ce81c6870558a The difference is the ordering of the rules. With AM_GLIB_GNU_GETTEXT appearing after IT_PROG_INTLTOOL, the --disable-nls arg to configure is broken. Thus this change is safe Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
