On Thu, Jan 26, 2012 at 5:37 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > I think it would be desirable to add a Makefile.am rule "make nsis" > and then trigger that from 'autobuild.sh' when we're doing the > Mingw32 build, so we regression test it. ack, though it will need first a "make install", as we don't really want to pick up file in the build tree, under src/.libs etc.. > Seems like this file needs to be processed during build to > subsitute in 'i686-pc-mingw32' or 'i686-w64-mingw32' as > present in the host toolchain yes, this was solved in the updated patch series. Also using a DESTDIR variable, so we don't need to install to root, which makes it easier to create during a rpm build. -- Marc-André Lureau